Changeset [59e8505e85ec4d529e96a0fe9814526cfdceb169] by Jonas S

August 16th, 2017 @ 07:52 AM

Fix travis update rspec (#867)

  • sunspot_solr: Fix travis: No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

  • sunspot: update rspec to 2.99

  • sunspot: Convert specs to RSpec 2.99.2 syntax with Transpec

This conversion is done by Transpec 3.3.0 with the following command:
transpec

  • 744 conversions from: obj.should to: expect(obj).to

  • 289 conversions from: == expected to: eq(expected)

  • 60 conversions from: obj.should_not to: expect(obj).not_to

  • 49 conversions from: lambda { }.should to: expect { }.to

  • 47 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message)

  • 11 conversions from: > expected to: be > expected

  • 11 conversions from: obj.should have(n).commits to: expect(obj.commits.size).to eq(n)

  • 8 conversions from: obj.stub(:message) to: allow(obj).to receive(:message)

  • 5 conversions from: obj.should have(n).soft_commits to: expect(obj.soft_commits.size).to eq(n)

  • 4 conversions from: =~ /pattern/ to: match(/pattern/)

  • 4 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message)

  • 3 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message)

  • 3 conversions from: it { should_not ... } to: it { is_expected.not_to ... }

  • 3 conversions from: obj.should_receive(:message).and_return { value } to: obj.should_receive(:message) { value }

  • 2 conversions from: < expected to: be < expected

  • 2 conversions from: collection.should have(n).items to: expect(collection.size).to eq(n)

  • 2 conversions from: it { should ... } to: it { is_expected.to ... }

  • 2 conversions from: lambda { }.should_not to: expect { }.not_to

  • 2 conversions from: obj.should have(n).adds to: expect(obj.adds.size).to eq(n)

  • 1 conversion from: =~ [1, 2] to: match_array([1, 2])

  • 1 conversion from: Klass.any_instance.should_receive(:message) to: expect_any_instance_of(Klass).to receive(:message)

  • 1 conversion from: obj.should have(n).highlights to: expect(obj.highlights.size).to eq(n)

  • 1 conversion from: obj.should have(n).highlights(...) to: expect(obj.highlights(...).size).to eq(n)

  • 1 conversion from: obj.should have(n).optims to: expect(obj.optims.size).to eq(n)

  • 1 conversion from: obj.should have(n).results to: expect(obj.results.size).to eq(n)

  • 1 conversion from: obj.should have(n).rows to: expect(obj.rows.size).to eq(n)

  • 1 conversion from: obj.should have(n).rows(...) to: expect(obj.rows(...).size).to eq(n)

  • 1 conversion from: obj.should have(n).searches to: expect(obj.searches.size).to eq(n)

  • 1 conversion from: pending to: skip

For more details: https://github.com/yujinakayama/transpec#supported-conversions

  • sunspot: update rspec to 3.6

  • sunspot_rails: Convert specs to RSpec 3.6.0 syntax with Transpec

This conversion is done by Transpec 3.3.0 with the following command:
transpec --rspec-command "rake spec RAILS=4.2.0"

  • 116 conversions from: obj.should to: expect(obj).to

  • 89 conversions from: == expected to: eq(expected)

  • 32 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message)

  • 28 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message)

  • 11 conversions from: obj.stub(:message => value) to: allow(obj).to receive_messages(:message => value)

  • 6 conversions from: obj.should_not to: expect(obj).not_to

  • 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message)

  • 3 conversions from: be_true to: be_truthy

  • 2 conversions from: lambda { }.should_not to: expect { }.not_to

  • 1 conversion from: =~ /pattern/ to: match(/pattern/)

  • 1 conversion from: Klass.any_instance.should_not_receive(:message) to: expect_any_instance_of(Klass).not_to receive(:message)

  • 1 conversion from: Klass.any_instance.should_receive(:message) to: expect_any_instance_of(Klass).to receive(:message)

  • 1 conversion from: be_false to: be_falsey

  • 1 conversion from: lambda { }.should to: expect { }.to

  • 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! }

For more details: https://github.com/yujinakayama/transpec#supported-conversions

Committed by Jonas S

  • A sunspot/.rspec
  • M sunspot/spec/api/adapters_spec.rb
  • M sunspot/spec/api/batcher_spec.rb
  • M sunspot/spec/api/binding_spec.rb
  • M sunspot/spec/api/class_set_spec.rb
  • M sunspot/spec/api/hit_enumerable_spec.rb
  • M sunspot/spec/api/indexer/attributes_spec.rb
  • M sunspot/spec/api/indexer/batch_spec.rb
  • M sunspot/spec/api/indexer/dynamic_fields_spec.rb
  • M sunspot/spec/api/indexer/fixed_fields_spec.rb
  • M sunspot/spec/api/indexer/fulltext_spec.rb
  • M sunspot/spec/api/indexer/removal_spec.rb
  • M sunspot/spec/api/indexer_spec.rb
  • M sunspot/spec/api/query/advanced_manipulation_examples.rb
  • M sunspot/spec/api/query/connectives_examples.rb
  • M sunspot/spec/api/query/dsl_spec.rb
  • M sunspot/spec/api/query/dynamic_fields_examples.rb
  • M sunspot/spec/api/query/faceting_examples.rb
  • M sunspot/spec/api/query/fulltext_examples.rb
  • M sunspot/spec/api/query/function_spec.rb
  • M sunspot/spec/api/query/geo_examples.rb
  • M sunspot/spec/api/query/group_spec.rb
  • M sunspot/spec/api/query/highlighting_examples.rb
  • M sunspot/spec/api/query/join_spec.rb
  • M sunspot/spec/api/query/more_like_this_spec.rb
  • M sunspot/spec/api/query/ordering_pagination_examples.rb
  • M sunspot/spec/api/query/scope_examples.rb
  • M sunspot/spec/api/query/spatial_examples.rb
  • M sunspot/spec/api/query/spellcheck_examples.rb
  • M sunspot/spec/api/query/standard_spec.rb
  • M sunspot/spec/api/query/stats_examples.rb
  • M sunspot/spec/api/query/text_field_scoping_examples.rb
  • M sunspot/spec/api/query/types_spec.rb
  • M sunspot/spec/api/search/cursor_paginated_collection_spec.rb
  • M sunspot/spec/api/search/dynamic_fields_spec.rb
  • M sunspot/spec/api/search/faceting_spec.rb
  • M sunspot/spec/api/search/highlighting_spec.rb
  • M sunspot/spec/api/search/hits_spec.rb
  • M sunspot/spec/api/search/paginated_collection_spec.rb
  • M sunspot/spec/api/search/results_spec.rb
  • M sunspot/spec/api/search/search_spec.rb
  • M sunspot/spec/api/search/stats_spec.rb
  • M sunspot/spec/api/session_proxy/class_sharding_session_proxy_spec.rb
  • M sunspot/spec/api/session_proxy/id_sharding_session_proxy_spec.rb
  • M sunspot/spec/api/session_proxy/master_slave_session_proxy_spec.rb
  • M sunspot/spec/api/session_proxy/retry_5xx_session_proxy_spec.rb
  • M sunspot/spec/api/session_proxy/sharding_session_proxy_spec.rb
  • M sunspot/spec/api/session_proxy/silent_fail_session_proxy_spec.rb
  • M sunspot/spec/api/session_proxy/spec_helper.rb
  • M sunspot/spec/api/session_proxy/thread_local_session_proxy_spec.rb
  • M sunspot/spec/api/session_spec.rb
  • M sunspot/spec/api/sunspot_spec.rb
  • M sunspot/spec/integration/atomic_updates_spec.rb
  • M sunspot/spec/integration/dynamic_fields_spec.rb
  • M sunspot/spec/integration/faceting_spec.rb
  • M sunspot/spec/integration/field_grouping_spec.rb
  • M sunspot/spec/integration/field_lists_spec.rb
  • M sunspot/spec/integration/geospatial_spec.rb
  • M sunspot/spec/integration/highlighting_spec.rb
  • M sunspot/spec/integration/indexing_spec.rb
  • M sunspot/spec/integration/keyword_search_spec.rb
  • M sunspot/spec/integration/local_search_spec.rb
  • M sunspot/spec/integration/more_like_this_spec.rb
  • M sunspot/spec/integration/scoped_search_spec.rb
  • M sunspot/spec/integration/spellcheck_spec.rb
  • M sunspot/spec/integration/stats_spec.rb
  • M sunspot/spec/integration/stored_fields_spec.rb
  • M sunspot/spec/integration/test_pagination.rb
  • M sunspot/spec/integration/unicode_spec.rb
  • M sunspot/spec/spec_helper.rb
  • M sunspot/sunspot.gemspec
  • M sunspot_rails/gemfiles/rails-3.0.0
  • M sunspot_rails/gemfiles/rails-3.1.0
  • M sunspot_rails/gemfiles/rails-3.2.0
  • M sunspot_rails/gemfiles/rails-4.0.0
  • M sunspot_rails/gemfiles/rails-4.1.0
  • M sunspot_rails/gemfiles/rails-4.2.0
  • M sunspot_rails/gemfiles/rails-5.0
  • M sunspot_rails/spec/configuration_spec.rb
  • M sunspot_rails/spec/model_lifecycle_spec.rb
  • M sunspot_rails/spec/model_spec.rb
  • M sunspot_rails/spec/rake_task_spec.rb
  • M sunspot_rails/spec/request_lifecycle_spec.rb
  • M sunspot_rails/spec/searchable_spec.rb
  • M sunspot_rails/spec/server_spec.rb
  • M sunspot_rails/spec/session_spec.rb
  • M sunspot_rails/spec/shared_examples/indexed_after_save.rb
  • M sunspot_rails/spec/shared_examples/not_indexed_after_save.rb
  • M sunspot_rails/spec/spec_helper.rb
  • M sunspot_rails/spec/stub_session_proxy_spec.rb
  • M sunspot_rails/sunspot_rails.gemspec
  • M sunspot_solr/lib/sunspot/solr/server.rb
  • M sunspot_solr/spec/server_spec.rb
New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Awesome Solr interaction for Ruby